Open justin808 opened 9 years ago
Let me check all the commits. Are many!
@clbustos I just submitted the merge and I'm testing on my own production product.
Just tested on my own build. Seems fine. Not sure about Travis.
@clbustos Any status of this? I had to add another commit to indicate that an exception is being caused by an r value greater than 1. Any idea how this can happen?
@clbustos I figured out the issue. We had two series with the same values. Statsample shouldn't crash in that case.
@clbustos Any word on merging my changes?
Hi @justin808, thanks for the pull request! We're currently in the process of centralizing SciRuby's gems in the organization repositories. Can you reopen your PR on sciruby/statsample?
Thanks! I'll take a look at your PR as soon as I finish moving the other gems' issues there. :)
How do I re-open the PR? Maybe open a new PR?
Yes, I think that's the easiest way. I couldn't find anything in GitHub's documentation. :(
Here's the PR....It is OPEN. I get to this screen when i tried to recreate it.
Maybe if you close this pull request first? Then, in the "create new PR" interface, you can select to which repository you want to send the PR -- just select SciRuby/statsample.
I'm sorry, I don't know a better way to do this. =(
I'd like to know if any of these changes are helpful (or even incorrect). I'm using these changes in a production system.