clbustos / statsample

A suite for basic and advanced statistics on Ruby.
http://github.com/clbustos/statsample
BSD 3-Clause "New" or "Revised" License
403 stars 96 forks source link

Justin extensions #34

Open justin808 opened 9 years ago

justin808 commented 9 years ago

I'd like to know if any of these changes are helpful (or even incorrect). I'm using these changes in a production system.

Review on Reviewable

clbustos commented 9 years ago

Let me check all the commits. Are many!

justin808 commented 9 years ago

@clbustos I just submitted the merge and I'm testing on my own production product.

justin808 commented 9 years ago

Just tested on my own build. Seems fine. Not sure about Travis.

justin808 commented 9 years ago

@clbustos Any status of this? I had to add another commit to indicate that an exception is being caused by an r value greater than 1. Any idea how this can happen?

justin808 commented 9 years ago

@clbustos I figured out the issue. We had two series with the same values. Statsample shouldn't crash in that case.

justin808 commented 9 years ago

@clbustos Any word on merging my changes?

agarie commented 9 years ago

Hi @justin808, thanks for the pull request! We're currently in the process of centralizing SciRuby's gems in the organization repositories. Can you reopen your PR on sciruby/statsample?

Thanks! I'll take a look at your PR as soon as I finish moving the other gems' issues there. :)

justin808 commented 9 years ago

How do I re-open the PR? Maybe open a new PR?

agarie commented 9 years ago

Yes, I think that's the easiest way. I couldn't find anything in GitHub's documentation. :(

justin808 commented 9 years ago

Here's the PR....It is OPEN. I get to this screen when i tried to recreate it.

agarie commented 9 years ago

Maybe if you close this pull request first? Then, in the "create new PR" interface, you can select to which repository you want to send the PR -- just select SciRuby/statsample.

I'm sorry, I don't know a better way to do this. =(

justin808 commented 9 years ago

https://github.com/SciRuby/statsample/pull/8