search

clcarwin / sphereface_pytorch

A PyTorch Implementation of SphereFace.
MIT License
714 stars 172 forks source link

Myphi is not monotonically decreasing ? #23

Closed ywu36 closed 6 years ago

ywu36 commented 6 years ago

Dear clcarwin,

According to the original authors of sphereface, the "myphi" need to be a monotonically decreasing function. However, it is not in this implementation.

I'm wondering whether this will affect the final results of verification? And may I know the reason why you simplify the myphi?

Best regards, Yuhang

clcarwin commented 6 years ago

myphi(x) is monotonically decreasing when x>=0.