cldellow / sqlite-parquet-vtable

A SQLite vtable extension to read Parquet files
Apache License 2.0
267 stars 31 forks source link

don't needlessly rebuild the compression libraries #27

Closed cldellow closed 6 years ago

cldellow commented 6 years ago

Arrow will download and build the compression libraries (lz4, snappy, zlib, zstd, brotli).

And then we'll do it, too, because we want to compile the static libs with -fPIC.

I think we can opt out of this by passing the right flag to arrow's cmake and setting the appropriate flags in https://github.com/apache/arrow/blob/master/cpp/thirdparty/README.md

xhochy commented 6 years ago

Arrow also builds them with -fPIC so you could also use its builds. Otherwise setting the *_HOME variables will tell Arrow to pick up your builds.

cldellow commented 6 years ago

Ah, thank you! That's much preferable.

PS - thank you and all the other arrow/parquet committers for providing these libraries, they're fantastic.