codecov-io
commented
5 years ago Codecov Report
Merging #119 into master will increase coverage by
1%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #119 +/- ##
=======================================
+ Coverage 98.56% 99.56% +1%
=======================================
Files 8 8
Lines 696 696
=======================================
+ Hits 686 693 +7
+ Misses 10 3 -7| Impacted Files | Coverage Δ | |
|---|---|---|
| src/pyclts/__main__.py | 99.48% <0%> (+1.53%) |
:arrow_up: |
| src/pyclts/transcriptionsystem.py | 98.78% <0%> (+2.43%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 9e226da...e4f98e4. Read the comment docs.
Installation is currently failing on Python3 when the system default encoding is not utf-8, as
setup.pyis unable to decodeREADME.mdintolong_description(there are many extended characters there). This PR fixes it by relying on thecodecslibrary, which is probably the most common solution (alternatives working in both Python2 & 3 would be to use theiolibrary or to just droplong_description).When fixing the bug, I also ran into some strange issues on Travis (check the build history) which I was at first unable to replicate locally, even with fresh environments (testing with containers just like Travis). Turns out they have some cached version of
attrslibrary only for some environments which are not actively maintained (such as Py3.4), which was raising exceptions when runningcsvwtests. The solution is simple, just indicate the library version, and should probably be propagated to other repositories (I can take care of that with time, if agreed).