search

cldf-clts / clts-legacy

Cross-Linguistic Transcription Systems
Apache License 2.0
4 stars 3 forks source link

fixing buggies #122

Closed LinguList closed 5 years ago

xrotwang commented 5 years ago

@LinguList it seems a sound used in the tests was added. Can you run the test suite locally?

LinguList commented 5 years ago

will do soon...

LinguList commented 5 years ago

somehow, my pyteset doesn't work... it says: 

usage: pytest [options] [file_or_dir] [file_or_dir] [...]
pytest: error: unrecognized arguments: --cov
  inifile: /home/jmlist/projects/scripts/clts/setup.cfg
  rootdir: /home/jmlist/projects/scripts/clts
xrotwang commented 5 years ago

did you run pip install -r requirements.txt? This should install coverage, too, which provides support for the --cov option.

LinguList commented 5 years ago

ups, sorry, did not fetch the upstream.

platform linux -- Python 3.5.2, pytest-4.0.0, py-1.7.0, pluggy-0.8.0
rootdir: /home/jmlist/projects/scripts/clts, inifile: setup.cfg
plugins: mock-1.10.0, cov-2.6.0
collected 180 items                                                                                                                                  

tests/test_api.py .                                                                                                                            [  0%]
tests/test_cli.py .....                                                                                                                        [  3%]
tests/test_clts.py ........................................................................................................................... [ 71%]
.................................................                                                                                              [ 98%]
tests/test_transcriptionsystem.py .                                                                                                            [ 99%]
tests/test_util.py .                                                                                                                           [100%]

----------- coverage: platform linux, python 3.5.2-final-0 -----------
Name                                Stmts   Miss  Cover   Missing
-----------------------------------------------------------------
src/pyclts/__init__.py                  5      0   100%
src/pyclts/__main__.py                196      3    98%   149, 285-286
src/pyclts/api.py                      30      0   100%
src/pyclts/models.py                  202      0   100%
src/pyclts/soundclasses.py             29      0   100%
src/pyclts/transcriptiondata.py        13      0   100%
src/pyclts/transcriptionsystem.py     164      3    98%   158, 161, 177
src/pyclts/util.py                     57      0   100%
-----------------------------------------------------------------
TOTAL                                 696      6    99%

So it runs without errors, it seems to me.

LinguList commented 5 years ago

and yes, I was such an idiot to not submit one file...

LinguList commented 5 years ago

Okay, all my errors. This happens if you don't work on a project for half a year or so. I hope the current update finally fixes this, soo that "ä" is now accepted as valid sound in clts.

codecov-io commented 5 years ago

Codecov Report

Merging #122 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files           8        8           
  Lines         696      696           
=======================================
  Hits          693      693           
  Misses          3        3
Impacted Files Coverage Δ
src/pyclts/models.py 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0b1e08a...44ca726. Read the comment docs.

xrotwang commented 5 years ago

yep, looks good. feel free to merge.

LinguList commented 5 years ago

Okay, but good that the test suite is so consistent that it's not taking too long of a time to spot the problems. If @tresoldi makes the next major changes with @cormacanderson, it'll be a lot that awaits us, but it seems to still work robustly enough, so we can prepare next week's release...