search

cldf-clts / clts

Cross-Linguistic Transcription Systems
https://clts.clld.org
14 stars 3 forks source link

Syllabic modifier is empty in bipa/diacritics.tsv #129

Closed LinguList closed 5 months ago

LinguList commented 2 years ago

One of the syllabic modifier diacritics, the one above the sound, is not provided in the data, maybe also because it was not clear where it is actually used. This line should be deleted or updated. @xachab pointed to this in https://github.com/cldf-clts/pyclts/pull/46/

XachaB commented 2 years ago

Here is the faulty line:

https://github.com/cldf-clts/clts/blob/cccee296b1e54e653e1b4bea103bf0e870072765/pkg/transcriptionsystems/bipa/diacritics.tsv#L63

It should read:

◌̍  consonant   syllabicity syllabic        up
XachaB commented 2 years ago

I just submitted two PRs for the two possible fixes, you can pick the one you prefer :)

XachaB commented 2 years ago

wait, did you merge both ? This was an either/or situation

LinguList commented 2 years ago

Sorry, I did not understand this, but I corrected the cases, so the either or is an either now.

XachaB commented 2 years ago

Haha, sorry, I should have been clearer that I had prepared two merge requests, and the required action was picking only one and merging it ;). All good if it's fixed now

LinguList commented 5 months ago

The issue has been resolved now. The diacritics.tsv does no longer contain an empty element here.