search

cldf-clts / clts

Cross-Linguistic Transcription Systems
https://clts.clld.org
13 stars 3 forks source link

weak articulation #145

Closed LinguList closed 3 months ago

LinguList commented 3 months ago

@cormacanderson, I had to fix some lines, but it works now, and this change does not require to touch the code, so it integrates nicely.

LinguList commented 3 months ago

This PR goes close to the actual release. What is left to do is creating CLDF data, and to double check. In my opinoin, all tests run, and there are no problems. @xrotwang and @chrzyki, would you like to double check and make the release 3.3?

chrzyki commented 3 months ago

Yes, I can have a look as well. I'll test on this branch, release-3.3, correct?

LinguList commented 3 months ago

Yes, that would be my suggestion :-)

chrzyki commented 3 months ago

Add weak articulation to features here: https://github.com/cldf-clts/clts/pull/145/commits/463c13b752347e8c376e79dd818413b0057668ba

Apart from that, everything looks fine from my end. The only other thing before releasing would be to update the metadata: https://github.com/cldf-clts/clts/blob/release-3.3/metadata.json to 2024?

LinguList commented 3 months ago

Yes, metadata should be updated. Thanks! I would then be fine in merging and proceeding with the release.

xrotwang commented 3 months ago

I guess release is something I'd do, then, since it also involves updating the clld app.

LinguList commented 3 months ago

Yes, thanks @xrotwang !

chrzyki commented 3 months ago

Thanks! If there is anything else I can do to help with the release (here or with the clld app) please let me know.

xrotwang commented 3 months ago

Where does "3.3" come from as release tag? I'd tag this as "2.3.0".

LinguList commented 3 months ago

You are right. I got confused.