search

cldf-clts / pyclts

Apache License 2.0
11 stars 2 forks source link

Map fix #33

Closed LinguList closed 4 years ago

LinguList commented 4 years ago

@tresoldi, please check this PR, as this is the one I meant which ADDS the symbols. I must have forgotten to submit it.

codecov-io commented 4 years ago

Codecov Report

Merging #33 (5d58dcc) into master (a934e77) will decrease coverage by 2.80%. The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   91.76%   88.96%   -2.81%     
==========================================
  Files          31       32       +1     
  Lines        1458     1523      +65     
==========================================
+ Hits         1338     1355      +17     
- Misses        120      168      +48
Impacted Files Coverage Δ
src/pyclts/commands/map.py 8.69% <0.00%> (-1.07%) :arrow_down:
src/pyclts/commands/make_dataset.py 29.16% <29.16%> (ø)
src/pyclts/api.py 95.16% <50.00%> (-4.84%) :arrow_down:
src/pyclts/models.py 99.51% <50.00%> (-0.49%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a934e77...5d58dcc. Read the comment docs.

LinguList commented 4 years ago

More importantly, and this was again missed in the communication (?), you can now add one single dataset with the command clts make_dataset dataset, instead of makeing the full package. I am confused that this was not yet put to a PR, since I asked in another email, if the single mapping of a dataset works, and @tresoldi confirmed this, but this is not possible, as the code is only in this PR. So to be clear, the new workflow is like this:

  1. make the mapping in the source/ folder (it also adds the column SYMBOLS, for readability)
  2. type clts make_dataset DATASET, so a single dataset will be written to the pkg/transcriptiondata/ folder.
  3. make the PR

This will also lead to PRs much smaller in size. What we now also need is to include the SYMBOLS into our datasets in pkg, as I think they make the sounds more readable and make checking easier, as they also show the order transparently.