Suggested changes - Githubissues

cldf-clts / soundvectors

MIT License

1 stars 0 forks source link

Closed xrotwang closed 4 months ago

xrotwang commented 4 months ago

updated project scaffolding (removed mention of old name everywhere, added setup.cfg, adapted metadata)
add a method to check CLTS compat
fixed two instances where non-CLTS feature domain names were used.

LinguList commented 4 months ago

@arubehn, did you have a chance to check this?

arubehn commented 4 months ago

@LinguList I was just reviewing it as you commented :D

@xrotwang this looks really great, I appreciate your work!

LinguList commented 4 months ago

So having this merged now, the next step is uploading it to PyPi. We can do so tomorrow. With version 1.0, I'd say, then.

xrotwang commented 4 months ago

So having this merged now, the next step is uploading it to PyPi. We can do so tomorrow. With version 1.0, I'd say, then.

I'd have one more suggestion regarding refactoring the domain hierarchy handling. Will PR soon.