add family to cldfbench script

[FredericBlum]

@xrotwang I tried adding LanguageFamily to the cldf/languages.csv, but for some reason, it does not get added. The print statement I added to the cldfbench-script while iterating through raw/languages.csv works fine, but the LanguageTable does not receive a column Family. Could you have a look what I am doing wrong?

If you agree, I'd also add myself to the list of contributors to the dataset.

[xrotwang]

Will do. From a cursory glance, I'd say the problem is that "Family" is not added to the dataset schema - and only columns listed in the metadata are written to file. So you'd need to add a "Family" column here: https://github.com/cldf-datasets/doreco/blob/8a9e4b604e9b4840556dc94dd224693c53f7a6f7/cldfbench_doreco.py#L484-L489

[xrotwang]

Btw.: If we create a 1.2.1 release for this dataset, we'll have to make sure to limit the actual data to the corpora with appropriate licenses, as we did for 1.2.

[FredericBlum]

Thanks, I have managed to include Family now.

The last commit also removes the nd-languages.

[FredericBlum]

Ah, of course, I re-downloaded, but not delete the files previously so they all stayed there... thanks for checking on this! Are we good to merge now?

[xrotwang]

Yes. I think so.

Frederic Blum @.***> schrieb am Mi., 17. Apr. 2024, 22:08:

Ah, of course, I re-downloaded, but not delete the files previously so they all stayed there... thanks for checking on this! Are we good to merge now?

— Reply to this email directly, view it on GitHub https://github.com/cldf-datasets/doreco/pull/31#issuecomment-2062132259, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGUOKAKASPCSMM2GRC5KTLY53JCXAVCNFSM6AAAAABGKGVKXKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRSGEZTEMRVHE . You are receiving this because you were mentioned.Message ID: @.***>

[xrotwang]

@FredericBlum I'll add a CHANGES.md and do a release 1.2.1, ok?

[FredericBlum]

Great, thanks!