search

cldf / csvw

CSV on the web
Apache License 2.0
37 stars 6 forks source link

For DictReader: Empty dialect is not the default dialect #14

Closed Anaphory closed 6 years ago

Anaphory commented 6 years ago

Due to the test https://github.com/cldf/csvw/blob/29871bd79b37c829b5f542537b26014bb9c41161/src/csvw/dsv.py#L228 the None-dialect, which is the default argument for UnicodeReader, is different from the default dialect Dialect(), which does specify a non-empty default comment prefix and therefore does handle comment lines.

Is this behaving as intended?

xrotwang commented 6 years ago

Yes. Not specifying a dialect is supposed to be compatible with python std libs default csv reading behaviour.