search

cldf / csvw

CSV on the web
Apache License 2.0
37 stars 6 forks source link

Update metadata.py #28

Closed tresoldi closed 5 years ago

tresoldi commented 5 years ago

I suggest wrapping the Key name for output during validation. When the missing key name is a general database word, such as id or rows, the log can be confusing:

ValueError: mydataset/forms.csv:2 Key rows not found in table parameters.csv
codecov-io commented 5 years ago

Codecov Report

Merging #28 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #28   +/-   ##
======================================
  Coverage    99.9%   99.9%           
======================================
  Files          15      15           
  Lines        2112    2112           
======================================
  Hits         2110    2110           
  Misses          2       2
Impacted Files Coverage Δ
src/csvw/metadata.py 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e789ade...7bcba91. Read the comment docs.

xrotwang commented 5 years ago

@tresoldi I think this is too small a change to deserve its own bugfix release, though. Agree?

tresoldi commented 5 years ago

@xrotwang oh, totally agree. It was just that I was (un)lucky that the first parameter id in my file was rows, having me puzzled about "key rows"... :wink: