cldf / pycldf

python package to read and write CLDF datasets
https://cldf.clld.org
Apache License 2.0
15 stars 7 forks source link

allow missing values in latitude / longitude #94

Closed SamPassmore closed 5 years ago

SamPassmore commented 5 years ago

hi, this is a question more than an issue. I am building a cldf format database and am validating it using the terminal tool However I get many Warnings of missing data because the key in my language file is not valid if there is missing longitude and latitude values. (i think this is what is happening)

e.g. [33mWARNING[0m data/cldf/forms.csv:38122 Key 150 not found in table languages.csv[0m

Some of the languages it doesn't make sense to have Lat/Lon values. Is it possible to all NA's in the .json file somehow so these Warnings don't arise?

language.csv

ID        Name Latitude Longitude Glottocode
150 Old Aramaic       NA        NA   olda1245
xrotwang commented 5 years ago

I think the problem is more the NA - unless you specified this explicitly as value meaning "null" in these columns. The default for this is the empty string.

SamPassmore notifications@github.com schrieb am Do., 27. Juni 2019, 18:01:

hi, this is a question more than an issue. I am building a cldf format database and am validating it using the terminal tool However I get many Warnings of missing data because the key in my language file is not valid if there is missing longitude and latitude values. (i think this is what is happening)

e.g. [33mWARNING[0m data/cldf/forms.csv:38122 Key 150 not found in table languages.csv[0m

Some of the languages it doesn't make sense to have Lat/Lon values. Is it possible to all NA's in the .json file somehow so these Warnings don't arise?

language.csv

ID Name Latitude Longitude Glottocode 150 Old Aramaic NA NA olda1245

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cldf/pycldf/issues/94?email_source=notifications&email_token=AAGUOKFU4YMBASFEXLATBRDP4TP5XA5CNFSM4H35Q7SKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G4DWKDQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGUOKBUCJ3HTBEAPREA6WTP4TP5XANCNFSM4H35Q7SA .

SamPassmore commented 5 years ago

yes - this was it. thanks!