cldf / segments

Unicode Standard tokenization routines and orthography profile segmentation
Apache License 2.0
31 stars 13 forks source link

refactored into a more modern package #24

Closed xrotwang closed 6 years ago

xrotwang commented 6 years ago
codecov-io commented 6 years ago

Codecov Report

Merging #24 into master will decrease coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   99.24%   99.23%   -0.01%     
==========================================
  Files           9        6       -3     
  Lines         395      263     -132     
  Branches        0       56      +56     
==========================================
- Hits          392      261     -131     
+ Misses          3        0       -3     
- Partials        0        2       +2
Impacted Files Coverage Δ
src/segments/errors.py 100% <ø> (ø)
src/segments/tokenizer.py 100% <ø> (ø)
src/segments/util.py 100% <ø> (ø)
src/segments/tree.py 96.66% <ø> (ø)
src/segments/cli.py 100% <100%> (ø)
src/segments/__init__.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cef7aa4...4379e8a. Read the comment docs.

xrotwang commented 6 years ago

Note that the decreased test coverage is due to switching to measure branch coverage as well.

bambooforest commented 6 years ago

That was the only thing I was curious about. The rest looks "modern". Thanks for this!

xflr6 commented 6 years ago

@bambooforest: next time give me some minutes to complete my review :)

bambooforest commented 6 years ago

@xflr6 -- my fault, didn't see you on this, but good thing you are!