search

cldwalker / debugger

port of ruby-debug that works on 1.9.2 and 1.9.3
BSD 2-Clause "Simplified" License
846 stars 80 forks source link

Add support for 2.1.2 #126

Closed jiripospisil closed 10 years ago

jiripospisil commented 10 years ago

I'm not really familiar with the code base but it seems this is all it takes to get it working with 2.1.2p95.

Fixes #125

caarlos0 commented 10 years ago

+1

Krule commented 10 years ago

:+1:

lucascaton commented 10 years ago

+1

granolocks commented 10 years ago

:+1:

jsatk commented 10 years ago

👍

ivangranados commented 10 years ago

any updates on this failing test ? is it ready ?

flipkick commented 10 years ago

the test doesn't fail because of this commit, but because of using ruby 2 now instead of ruby 1.9 for running the rake tasks.

before in https://travis-ci.org/cldwalker/debugger/jobs/19734278 :

 rvm use 1.9.3 --install --binary --fuzzy

now in https://travis-ci.org/cldwalker/debugger/jobs/19734279 :

 rvm use 2.0.0 --install --binary --fuzzy

using ruby 2.0.0 here in the travis setup would also break the tests for a version without this commit. using ruby 1.9.3 the tests would pass with this commit.

kwent commented 10 years ago

+1

darthdeus commented 10 years ago

+1

backus commented 10 years ago

+1

alainmeier commented 10 years ago

+1

hallelujah commented 10 years ago

Known Issues

cldwalker commented 10 years ago

Closing since I'm scoping debugger to just 1.9.2 and 1.9.3. For more see https://github.com/cldwalker/debugger/issues/125#issuecomment-43353446