cldwalker / debugger

port of ruby-debug that works on 1.9.2 and 1.9.3
BSD 2-Clause "Simplified" License
845 stars 80 forks source link

Refactor for issue #57 #97

Closed eric-hu closed 11 years ago

eric-hu commented 11 years ago

@cldwalker this code can be further refactored, but I wanted to run the changes by you before it diverged from cldwalker/master further. Could you look it over and let me know what you think?

Overview:

cldwalker commented 11 years ago

Thanks for the pull. ruby2 support is a higher priority. I need to offload a todo list of what's needed there before looking at this. In the meantime, I welcome @astashov, @deivid-rodriguez or anyone else to code review

deivid-rodriguez commented 11 years ago

I've had a quick look into this. The option parser looks good. As per the other test, I'm not sure whether spawning a new shell process in a new thread is the best way to go... Maybe reducing the executable to parsing the options with that RdebugOptionParse class and calling the run method of another RdebugRunner class, and then just testing those two classes would be better? I'm just thinking loud...

eric-hu commented 11 years ago

@deivid-rodriguez thanks for the code review. I wasn't happy with the tests either, but wanted something that could run against the original code as-is to verify behavior as I changed things. I appreciate the suggestions on the tests and I'll work towards that direction.

deivid-rodriguez commented 11 years ago

No problem @eric-hu, I thinks this is a very nice enhancement and I'm looking forward to merging this into byebug as well.