cleanflight / blackbox-log-viewer

Interactive log viewer for flight logs recorded with blackbox
GNU General Public License v3.0
85 stars 43 forks source link

Separate the log parsing code out into a reusable library? #88

Closed qdrk closed 1 year ago

qdrk commented 2 years ago

Hi there, a long term follower of cleanflgiht blackbox log analysis here. I'm wondering if folks are fine to sparate the parsing code in flightlog_parser.js out into a reusable library that can be used by third-party apps? The reason for the ask is, with the current logging logic in the firmware, especially with all the field encodings and frame format, it's really hard to code something from ground-up (nor does it make much economic sense) just to work with the logging code that was written over 5 years ago. Hopefully with a separate library, it'll make things easier and encourage a richer ecosystem around PID tuning and issue diagnosis, as other developers can focus on high-level data representations instead of worrying about all the nitty-gritty encoding/frame format issues.

fedorcomander commented 2 years ago

there is pretty good c bb decoder available


Cheers, Alex

On 27 Dec 2021, at 19:34, qdrk @.***> wrote:

 Hi there, a long term follower of cleanflgiht blackbox log analysis here. I'm wondering if folks are fine to sparate the parsing code in flightlog_parser.js out into a reusable library that can be used by third-party apps? The reason for the ask is, with the current logging logic in the firmware, especially with all the field encodings and frame format, it's really hard to code something from ground-up (nor does it make much economic sense) just to work with the logging code that was written over 5 years ago. Hopefully with a separate library, it'll make things easier and encourage a richer ecosystem around PID tuning and issue diagnosis, as other developers can focus on high-level data representations instead of worrying about all the nitty-gritty encoding/frame format issues.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you are subscribed to this thread.

fedorcomander commented 2 years ago

But yeah, js lib would be nice to have (read/write). I literally needed one yesterday! Just bb-decoded it to csv and did the rest :)

On 27 Dec 2021, at 19:34, qdrk @.***> wrote:

Hi there, a long term follower of cleanflgiht blackbox log analysis here. I'm wondering if folks are fine to sparate the parsing code in flightlog_parser.js out into a reusable library that can be used by third-party apps? The reason for the ask is, with the current logging logic in the firmware, especially with all the field encodings and frame format, it's really hard to code something from ground-up (nor does it make much economic sense) just to work with the logging code that was written over 5 years ago. Hopefully with a separate library, it'll make things easier and encourage a richer ecosystem around PID tuning and issue diagnosis, as other developers can focus on high-level data representations instead of worrying about all the nitty-gritty encoding/frame format issues.

— Reply to this email directly, view it on GitHub https://github.com/cleanflight/blackbox-log-viewer/issues/88, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQBCCUDBJAUYPTSHM7233DUTCWT7ANCNFSM5K2Y2A4A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.