search

cleannrooster / Spellblade-Next

1 stars 2 forks source link

Ticking Entity Crash #20

Closed Karashok-Leo closed 8 months ago

Karashok-Leo commented 8 months ago

crash-2024-02-08_11.15.21-server.txt

cleannrooster commented 8 months ago

Hi, this is likely an issue with the Conjuring mod, I see no issue with the way I have it implemented.

In the LivingEntityMixin.java I see in the Conjuring mod repo, I see a case of LivingEntity cast to PlayerEntity unchecked, so this is likely the the cause of the issue that can be fixed on the end of the author of the Conjuring mod.

Here it is: https://github.com/wisp-forest/conjuring/blob/bdc3d1e49dbccbc9e970984824ea621c691bdb14/src/main/java/com/glisco/conjuring/mixin/LivingEntityMixin.java#L82

gliscowo commented 8 months ago

Hey, author of Conjuring Conjuring here. While I do agree that Conjuring's implementation of this check is probably not optimal, I'm rather confused as to how your mod would be triggering this crash. The only way I can see for that to happen is by causing damage using the PLAYER_ATTACK damage type... but without an actual player attacking? That seems wrong to me and like it would cause issues with other mods too.

Since I can't seem to find the implementation of the class causing the crash in this repo, could you maybe elaborate a bit further on why you believe that your code is not responsible as well?

Cheers

cleannrooster commented 7 months ago

Hi, I'm not sure how my code is allowing something that isn't a player attack to pass a player attack damage type check, I'll tell you if i figure it out.

On Sat, Feb 17, 2024 at 8:44 AM Lily @.***> wrote:

Hey, author of Conjuring Conjuring here. While I do agree that Conjuring's implementation of this check is probably not optimal, I'm rather confused as to how your mod would be triggering this crash. The only way I can see for that to happen is by causing damage using the PLAYER_ATTACK damage type... but without an actual player attacking? That seems wrong to me and like it would cause issues with other mods too.

Since I can't seem to find the implementation of the class causing the crash in this repo, could you maybe elaborate a bit further on why you believe that your code is not responsible as well?

Cheers

— Reply to this email directly, view it on GitHub https://github.com/cleannrooster/Spellblade-Next/issues/20#issuecomment-1950252995, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW4ADB34SENTZZLFBONUPFLYUDM5FAVCNFSM6AAAAABC65K35OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJQGI2TEOJZGU . You are receiving this because you modified the open/close state.Message ID: @.***>