cleanunicorn / mythos

CLI client for the MythX API
https://mythx.io/
20 stars 6 forks source link

Instruction on Windows installation missing #32

Closed sjukeshov closed 5 years ago

sjukeshov commented 5 years ago

I tried to install Mythos to Windows and get following

PS...> npm install -g cleanunicorn/mythos

> @cleanunicorn/mythos@0.5.2 prepack C:\Users\user\AppData\Roaming\npm-cache\_cacache\tmp\git-clone-bd60c8f4
> rm -rf lib && tsc --skipLibCheck && cp src/scanner.js lib/ && oclif-dev manifest && oclif-dev readme

"rm" is not internal or external command
npm ERR! premature close

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\user\AppData\Roaming\npm-cache\_logs\2019-04-04T06_46_07_176Z-debug.log
PS C:\mythx> npm -g install cleanunicorn/mythos

> @cleanunicorn/mythos@0.5.2 prepack C:\Users\user\AppData\Roaming\npm-cache\_cacache\tmp\git-clone-e0d3f4c4
> rm -rf lib && tsc --skipLibCheck && cp src/scanner.js lib/ && oclif-dev manifest && oclif-dev readme

"rm" is not internal or external command
npm ERR! premature close

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\user\AppData\Roaming\npm-cache\_logs\2019-04-04T06_47_39_862Z-debug.log
PS...> npm -g install @cleanunicorn/mythos
Нераспознанный токен в исходном тексте.
строка:1 знак:16
+ npm -g install  <<<< @cleanunicorn/mythos
   + CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
   + FullyQualifiedErrorId : UnrecognizedToken

I don't know if you ever consider Windows users but there is no instructions on how to install it. Also I'm getting errors above which are working on other OS but not this. There is a problem with export command there which should be investigated also to find out which command Windows users should do for MYTHX_ETH_ADDRESS and MYTHX_PASSWORD variables

cleanunicorn commented 5 years ago

Unfortunately I do not have an available Windows machine, I will install a VM if nobody can test and fix this.

The env variables are not the only way to set the credentials, they can also be set by adding the flags

  --mythxEthAddress=mythxEthAddress  (required)
  --mythxPassword=mythxPassword      (required)
cleanunicorn commented 5 years ago

This is related to this issue https://github.com/oclif/oclif/issues/56

cleanunicorn commented 5 years ago

Was able to install on Windows