clear-code / redmine_full_text_search

Full text search for Redmine
MIT License
61 stars 24 forks source link

Support Redmine master #127

Closed otegami closed 5 months ago

otegami commented 5 months ago

close: https://github.com/clear-code/redmine_full_text_search/issues/126

What I didn't

kou commented 5 months ago

Could you split this to 4 PRs?

  1. Rails uses the ApplicationRecord as a default parent class of all models instead of ActiveRecord::Base
  2. In Rails 7, the .schema_format= API is moved from ActiveRecord::Base to ActiveRecord
  3. Use the actual path under /plugins using symbolic links
  4. In Rails v7.1, ActiveSupport::TestCase.fixture_path will be deprecated

The 2. must be the first PR because it's the cause of current CI failure: https://github.com/clear-code/redmine_full_text_search/actions/runs/8126442854/job/22210192673#step:8:301

NoMethodError: undefined method `schema_format=' for ActiveRecord::Base:Class
otegami commented 5 months ago

Sure. I will close this PR and make 4 PRs.