clear-code / redmine_full_text_search

Full text search for Redmine
MIT License
61 stars 24 forks source link

Search results have same item #61

Open two-pack opened 5 years ago

two-pack commented 5 years ago

Search results have same item when some fields match keyword of searching. But I think to show only one item on search results.

How to reproduce

  1. Add custom fields for issue.
  2. Create new issue, and set test-keyword to Description and your custom fields.
  3. Search with test-keyword. Searching results has same item of your issue.

Example I attach my case's screenshot. My custom fields are cf1 and cf2 and searching keyword is Results. 3 items, issue 5, are on the list, but I think the list should have only a item. screenshot_search_results

In Japanese, 説明とカスタムフィールドなど、検索される要素にそれぞれ検索キーワードが含まれる場合、同じチケットなどが複数列挙されます。検索結果としては、同じチケットが複数表示されない方が良いと思いますがいかがでしょうか?

kou commented 5 years ago

It makes sense. We shouldn't show the same issue multiple times. It's better that we put sub search result items for the issue like Google did:

google-sub-items

two-pack commented 5 years ago

I'm glad to see your comment. IMHO, Google's example is not appropriate in this case, because all items are the same link and It does not matter which field matches it. So I think the first result is enough.

kou commented 5 years ago

Ah, sorry. The example isn't good. I just want to say that it's better that we also show custom fields values too instead of just showing the ticket description.

two-pack commented 5 years ago

I got it. It sounds good :)