search

clearbit / clearbit-go

Go bindings for Clearbit
MIT License
12 stars 11 forks source link

Company.marketCap casting int to string field #18

Closed philipithomas closed 6 years ago

philipithomas commented 6 years ago

I'm getting this error in production:

screen shot 2017-12-12 at 11 07 14 am

Simple fix would be converting the marketCap string field to an int. However, I'm concerned that the API isn't returning a consistent type.

@davidlumley @mattatcha - can you confirm the API return type? Until this is fixed, enrichment is erroring in our app while chewing through our quota . . .

philipithomas commented 6 years ago

Here's the line https://github.com/clearbit/clearbit-go/blob/master/clearbit/company.go#L86

davidlumley commented 6 years ago

Looks like it was accidentally changed from an int to a string here: https://github.com/clearbit/clearbit-go/commit/ce4492d81bdb72e8f7a6e7cda321226a8eb93538

Would you mind submitting a PR to change it back? 🙏