search

clearbit / clearbit-node

Node library for querying the Clearbit business intelligence APIs
https://clearbit.com/docs
MIT License
69 stars 35 forks source link

Fix auth #1

Closed maccman closed 10 years ago

maccman commented 10 years ago

@bendrucker what do you think?

maccman commented 10 years ago

Not quite sure why, perhaps is the version of needle I'm using (0.7.10), but the auth doesn't work unless the password is blank. If this branch works for you I'll fix the tests.

bendrucker commented 10 years ago

I've managed to screw up basic auth way too much. Related: https://github.com/mikeal/request/issues/602

Really just depends on what the server is expecting. Needle implements this correctly. Request used implicitly call undefined.toString() when no password was provided. Will take care of tests and merge now.