Cannot install package without git

clearbit / clearbit-node

Node library for querying the Clearbit business intelligence APIs

https://clearbit.com/docs

MIT License

69 stars 35 forks source link

Cannot install package without git #45

Open neilpalima opened 4 years ago

neilpalima commented 4 years ago

npm ERR! code ENOGIT
npm ERR! Error while executing:
npm ERR! undefined ls-remote -h -t ssh://git@github.com/clearbit/needle.git
npm ERR! 
npm ERR! undefined
npm ERR! No git binary found in $PATH
npm ERR!
npm ERR! Failed using git.
npm ERR! Please check if you have git installed and in your PATH.

We are using docker and does not have git on it.

geekgonecrazy commented 2 years ago

Can confirm this one caught me over a year later. Trying to build an application in a docker image: node:14-alpine and alpine doesn't have git so this caused things to blow up.

Do you intend to get your fix needing a fork of needle into upstream? Is there an upstream PR we can bump to make sure it gets in and this need for pulling in your forked needle package goes away?