search

clearbit / clearbit-node

Node library for querying the Clearbit business intelligence APIs
https://clearbit.com/docs
MIT License
69 stars 35 forks source link

Add flagging API. #6

Closed maccman closed 9 years ago

maccman commented 9 years ago

@bendrucker what do you think about the API for adding instance vars?

bendrucker commented 9 years ago

What is that method going to do? I will probably rethink how these resources get created (yet again) if there's going to be more complicated stuff going on.

maccman commented 9 years ago

Flagging essentially tells us the data may be wrong. I imagine we'll start adding more instance methods onto the returned objects (like subscribe/unsubscribe).

If you don't mind, I'm going to merge this first and then we can look at refactoring it.

bendrucker commented 9 years ago

Figured. Fine by me. Version is incorrect though. Should be a minor bump not a patch.

maccman commented 9 years ago

Ah, so 1.1.0 ? Can it not be a minor bump since we're not changing the existing API (just adding to it)?

bendrucker commented 9 years ago

Yup! Semver says:

Major: Breaking change Minor: Nonbreaking addition Patch: Bugfixes

maccman commented 9 years ago

Makes sense!