family_name and given_name are unused when provided as defaults

clearbit / clearbit-slack

Clearbit enrichment data in a Slack channel

MIT License

35 stars 4 forks source link

family_name and given_name are unused when provided as defaults #22

Closed martin308 closed 7 years ago

martin308 commented 7 years ago

It seems that only full_name is sent through to slack so it seems like there is no point in populating given_name and family_name as suggested in the readme. This allows people to provide full_name instead which is sent through to slack

harlow commented 7 years ago

@martin308 looks like there is a conflict w/ master. Mind rebasing and fixing the conflict?

martin308 commented 7 years ago

@harlow should be all resolved now, it conflicted with my other PR