clearbit / clearbit-slack

Clearbit enrichment data in a Slack channel
MIT License
35 stars 4 forks source link

Gem uses an old `slack-notifier` version #28

Open Laukei opened 3 years ago

Laukei commented 3 years ago

Hello! Thanks for making and maintaining clearbit-slack. I've been updating gemfiles recently in our software stack to keep them current and this has become a blocker on updating other gems.

The slack-notifier version required by clearbit-slack is capped at 1.5.1. This version of slack-notifier is 5 years old. When trying to update to a more current version of the notifier, I get

Bundler could not find compatible versions for gem "slack-notifier":
  In Gemfile:
    slack-notifier (~> 2.3)

    clearbit-slack was resolved to 0.2.2, which depends on
      slack-notifier (>= 1.5.1, ~> 1.5.1)

The latest version of slack-notiifer is ~3 years old (2.3.2) (changelog). It looks like the only breaking change is the way defaults are set using a block during initialization.

It would be good if clearbit-slack supported this version. Thanks!

harlow commented 3 years ago

@Laukei thanks for the note. Are you up for bumping the version and creating a PR?

Laukei commented 3 years ago

@harlow Thanks for accepting the PR! Do you have an approximate timeline for the release of an updated gem? It will help me plan my sprint as we have a pre-Christmas code freeze. Thanks!

Laukei commented 3 years ago

Hello again @harlow! Hope you had a good Christmas and new year. Would it be possible to get a new gem built from the updated clearbit-slack if my code contribution is working correctly? Thanks!

Laukei commented 3 years ago

Hello! 👋 Just looking to see if the updated gem was likely to be built any time soon? Cheers!

Laukei commented 2 years ago

👋 Howdy! It's been a couple of years since I filed a PR to fix this and it was merged, but there's still no new release, and I'm loathe to muddy the rubygems waters by forking the project unless it's the only option. Please let me know if a new release is likely or if I should go ahead and build my own gem? 🙇‍♂️