search

clearbold / artx

1 stars 0 forks source link

Check tap targets on nav icons #11

Closed heymarkreeves closed 10 years ago

heymarkreeves commented 10 years ago

Hi, Sherri!

Playing around with the main screen yesterday, I had a bit of trouble consistently hitting the icons for the left & right nav, on my iPhone 5c, with my thumb or index finger. Sometimes they wouldn't respond and I'd tap multiple times. Sometimes I just couldn't hit them. In contrast, the star icon responded as I expected every time. Can you reproduce? I'm not sure it's the size of the tap target, or the proximity to the edge of the screen.

Thanks!

Mark

SherriAlexander commented 10 years ago

I made a few tweaks -- I think it's better now, though not 100%. I can hit the menu button just about every time, but the tags button seems to be harder to hit even though they're identical in CSS terms (I'm averaging more like 85-90% on the tags button).

It's possible that there is some conflict going on between some touch speed adjustments made by sidr.js (the sliding panel plugin I'm using) and fastclick.js (a general touch speed plugin which removes the tap delay that's native to iOS and other touch devices in browser). Try out the improvements that I've made so far, and if it still seems to be problematic, I can go in and hack the sidr.js plugin to remove its touch speed code or tell fastclick.js to ignore the sidr triggers, either one. Thanks!

SherriAlexander commented 10 years ago

Another thing I just noted -- my accuracy on the Tags one goes way up if I wait a little bit between taps. If I try to tap quickly (open-close-open-close real fast), the taps don't seem to register while things are animating. It's possible that we're hitting an edge case, as I don't think most people will be toggling that back and forth real fast?

heymarkreeves commented 10 years ago

It might be worth noting that my observations were from the home screen "app" view, not in Safari. I do agree that part of it might be the tap delay.

I'll play some more, but let's leave this open to revisit and anticipate feedback while we're discussing it.

Thanks!

heymarkreeves commented 10 years ago

Keeping this open to review at some point.