search

clearbold / artx

1 stars 0 forks source link

When image not available, default to an image of the venue #24

Closed jamiefolsom closed 9 years ago

heymarkreeves commented 9 years ago

Hi, @jamiefolsom: Can this happen in the API? Can you detect the absence of an image for an event and supply its venue image in its place? That way the API is responsible for determining the content that should be shown. Let me know what you think.

Thanks!

Mark

jamiefolsom commented 9 years ago

Hi @circa1977 -- Makes sense to me. I'll chat with @mailbackwards about it.

mailbackwards commented 9 years ago

@circa1977 I agree that it makes more sense logically for the API to check, but it would be inefficient to do this on the backend at request time. Instead I could set up a daily cron job that checks for bad images and replaces them. This would mean we'd still get "image not available" in rare cases when the image goes down and the cron hasn't run yet (I wonder if we could have a friendlier default?), but it would be much less frequent, and it would keep the content selection process in the API.

heymarkreeves commented 9 years ago

Thanks, Liam! Would it be better to just output "ArtBotArtbot" on black in cases where an image is not available? Eventually that would be replaced by a real logo.

mailbackwards commented 9 years ago

Sure, that sounds like a good default-- but FYI it's currently "Artbot", lower case b, subject to change :)

heymarkreeves commented 9 years ago

Thanks!

heymarkreeves commented 9 years ago

@SherriAlexander Can you replace the "Image Not Available" image with "Artbot" in the teal color on black? Consider it a placeholder logo in the case we're currently supporting as an error. Thanks!

SherriAlexander commented 9 years ago

I've updated the "Image Not Available" image to be "Artbot" in teal on black -- let me know if there are any further tweaks and I can change the text as needed. :) Thanks!