search

clearbold / artx

1 stars 0 forks source link

Bottom carousel—when there's only one event, left justify image. Also, this image appears bigger on my iPhone 4; want it to remain same size #35

Closed jamiefolsom closed 9 years ago

heymarkreeves commented 9 years ago

To be able to left justify the image and control its dimensions, we'd have to fork how the Favorites bar is rendered based on the number of slides, using our own CSS for < 3 favorites and initializing bxSlider when > 2 favorites. That also means we'd need to remove and re-initialize bxSlider on the fly every time an event was un/favorited.

bxSlider is the best responsive carousel plugin for jQuery we've found that handles swipe events really well. It's also managing how each slide is rendered in the available space, with no override options to constraint the image size or positioning based on the number of slides.

(Also a consideration: All sliders are handled by the same scripting, including Related Events, etc.)

I have reservations on this one for 2 reasons:

  1. It's a considerable new effort, to code multiple versions of the bottom bar for slider/non-slider states.
  2. We're undoing a lot of what bxSlider does optimally. Left alignment is counter to "distribute evenly," which is what bxSlider does for 1, 2, 3...n images.
desigonz commented 9 years ago

Let's add this issue to our items to discuss. We'd like to consider possible solutions for the center/left alignment of the bottom carousel.

SherriAlexander commented 9 years ago

The carousel items will now always be a reliable size, and will be left-aligned within the container. I was able to achieve this without using the dummy events returned by the API, so those are not currently needed.

If you are using the staging server as a standalone app, you may need to close it, delete it, clear your Safari browser cache, and create a new standalone app from the staging server in order to see the changes.

Let me know what the team thinks, when you can -- Thanks!

mailbackwards commented 9 years ago

Thanks Sherri, the left justifying looks great. I just want to confirm that you will not need the dummy events...I'd love to clean that out of the API if it's not necessary. If so we can close 68 and 69 in the API repo too. But if the dummy events might still be necessary soon, I can keep it in for now.

heymarkreeves commented 9 years ago

Hi, @mailbackwards! Let's wait for Sherri to confirm this afternoon, but I do believe we were able to make this work without the dummy events.

SherriAlexander commented 9 years ago

Hey there! Yes, we can definitely clean out the dummy events and cross those issues off our lists. :) Thanks!