Testing Remember Me

[heymarkreeves]

Hi, Sherri!

I took the following steps:

1) Cleared all cached/private data in Chrome on iOS 2) Visited staging.artx.clearbold.com 3) Was prompted to sign up, I clicked the sign in link 4) Signed in 5) Confirmed that my email address was atop the menu 6) Confirmed on the Settings screen that the Remember Me box was checked by default (it flashed with an unchecked box, and then converted to a green checkmark -- Was this to include that if I saved my settings or to indicate that the server sees me as set that way?) 7) Closed the browser tab 8) Exited Chrome and used the iOS switcher to quit the Chrome app 9) Relaunched the Chrome app without clearing private settings 10) Visited the staging.artx.clearbold.com URL from history 11) Did not receive the sign up modal, but was not logged in either; My email address is not atop the menu and I have a sign in link in the nav 12) Logged in again 13) Went to Settings 14) Hit Save on the first set of fields, with the intent to capture the checked "Keep me logged in" setting (Note sometimes the active state on the button appears to get stuck) 15) Closed browser tab 16) Quit app 17) Relaunched Chrome 18) Loaded staging.artx.clearbold.com from History 19) Now I have an active session

So it seems that while the checkbox is prepopulated on the Settings screen, the setting is not in effect unless I save those Settings?

Aside from that question, this looks good. If I clear all browser data again and hit the site, I get the sign up modal.

Mark

[SherriAlexander]

Hey there! Yes -- everything above the Save button requires the Save button to be pressed in order to submit it to the server, so I'd figured that would be the default for this checkbox as well. If we need it to send a separate Ajax request, I can set that up, but it seems to go against what we'd already established for this form?

[heymarkreeves]

Hi, @SherriAlexander!

You probably went back and forth with Liam and Desi on this a bit, so I don't want to contradict anything already resolved. I'm not sure if this is an issue or not, based on my perspective as a tester:

If the intent is to automatically enable Remember Me on new signups, then the behavior of defaulting the Settings checkbox to enabled so that it takes effect when they hit save the first time makes sense.

As I was testing whether or not it was working, seeing that checkbox led me to believe that I had it enabled when in fact I did not. It was just defaulted to enabled in that settings panel, because for my account that's the first time I encountered it.

For me, because I was testing the functionality, it was misleading and confusing. Seeing an option enabled in my settings led me to believe I had that option enabled when, in fact, with a pre-existing account and without saving those settings, I did not yet.

The question becomes: Does the checkbox reflect an enabled setting the first time you see it? Or a default until you save? And how much of an issue is that as it only affects non-new users whom I assume are defaulting to Remember Me when they sign up?

Thanks!

Mark

[SherriAlexander]

Hey there!

Liam and I actually set something up so that all accounts should now have it automatically enabled, even pre-existing accounts (because we ran into the same problem). Sorry about the confusion there!

All fields on the Settings page start out blank, then the scripts ping the API for that user and fill them in. If the checkbox appears checked after the page is fully loaded, it should be because the page pings the API and finds that Remember Me = true.

[heymarkreeves]

Ah, Ok. That sounds consistent. But that implies something was off in my testing, because Remember Me did not work until I hit Save on that screen.

I think this is lower priority than the other items I cited, because all new users will get the right defaults, but may come up in their testing.

Thanks!

[SherriAlexander]

Sounds good -- I have a LOT of pre-existing users that I haven't touched yet, so I should be able to swing back and double-check to make sure this is behaving as expected. :) Thanks!

[SherriAlexander]

Hey there, Mark!

I just did some tests with my pre-existing users and a new user that I created for the purpose. From what I can see (via both console log and observation), the following scenarios all are working correctly:

• Remember Me is showing as selected in Settings and working as expected (using localStorage) for pre-existing users (who have not explicitly changed it in Settings and saved the preferences)
• Remember Me is showing as selected in Settings and working as expected (using localStorage) for new users (who have not explicitly changed it in Settings and saved the preferences)
• Remember Me is correctly switching from localStorage to sessionStorage when the user changes it from true to false in Settings and saves. This persists through logout and logging back in, and displays correctly in Settings.
• Remember Me is correctly switching from sessionStorage to localStorage when the user changes it from false to true in Settings and saves. This persists through logout and logging back in, and displays correctly in Settings.

So I think we're all set, unless I've missed something -- let me know what you think. Thanks!

[heymarkreeves]

I'm going to go ahead and let the team start testing - Thanks!