search

clearcontainers / agent

Virtual Machine agent for hardware virtualized containers
Apache License 2.0
27 stars 12 forks source link

ci: enable go static checkers #46

Open grahamwhaley opened 7 years ago

grahamwhaley commented 7 years ago

As far as I can tell we are not running any of the go static checkers on this repo. It doesn't look like we invoke them from our .ci or that they are invoked from the clearcontainers/tests scrips we invoke either. I also checked the Travis logs and could see no evidence. We should probably start by importing the go-static-checks.sh script once we have a nicely fixed up version - see https://github.com/clearcontainers/tests/pull/110 for more info.

btw, currently the repo seems to be showing no problems from a hand run of the static checkers - take a bow the relevant developers :-)

grahamwhaley commented 7 years ago

I note, houndci that we use on this repo uses golint for checking go code already - so we could drop that from the go-static-checks script if we need, but the overheads are probably small enough to just leave it be unless it becomes an issue.