search

clearcontainers / osbuilder

Clear Containers guest OS building scripts
20 stars 12 forks source link

docs: runc doesn't need to be the default runtime #23

Closed jodh-intel closed 7 years ago

jodh-intel commented 7 years ago

The README says that one of the requirements is that, "runc is configured as default runtime" however, Makefile calls --runtime runc so it doesn't matter what the default runtime is.

grahamwhaley commented 7 years ago

I have a feeling the issue is with the docker build step, not the docker run step, where having CC as the default runtime shows up a 9pfs unlink style problem when building the initial image. And iirc, you cannot state a runtime to use for docker build. That is iirc - so, asking @jcvenegas for confirmation :-)

jodh-intel commented 7 years ago

Ah - that would make sense. But we should document this in the README as it's currently unclear "why".

jcvenegas commented 7 years ago

@jodh-intel @grahamwhaley yes, is because of docker build, sadly it does not support to change the runtime in that command.

jodh-intel commented 7 years ago

Limitations is documented in #8. Closing this.