search

clearcontainers / osbuilder

Clear Containers guest OS building scripts
20 stars 12 forks source link

os: Add a default shell to mini-os #37

Closed jcvenegas closed 6 years ago

jcvenegas commented 6 years ago

Need to provide a shell for vm debuging.

Fixes: #36

Signed-off-by: Jose Carlos Venegas Munoz jose.carlos.venegas.munoz@intel.com

jodh-intel commented 6 years ago

Since this tool creates custom images for development/debugging, I think giving the ability to add a shell is reasonable in most scenarios. However, this might not be required for some users and does bloat the image beyond the current minimal config.

As such, why not add an option / env var to also have a shell included? Alternatively, we could just document in make help that if you want a shell, set EXTRA_PKGS="bash-bin"?

jodh-intel commented 6 years ago

Any update on this?

mcastelino commented 6 years ago

@jcvenegas @jodh-intel @sameo @grahamwhaley can we close on this. IMO we should either include a shell in the default distribution. Or we should include two images (a debug and a release image). I am ok with either approach. But asking the user to build the image just to debug is not the right decision.