packages: Refactor setup scripts

clearcontainers / packaging

Packaging data for Clear Containers

11 stars 11 forks source link

packages: Refactor setup scripts #167

Closed erick0z closed 7 years ago

erick0z commented 7 years ago

this series of commits refactor the setup script allowing new features, needed for some use cases and adding a better user experience.

Splitted common functions to scripts/pkglib.sh

Fixes #166

jodh-intel commented 7 years ago

This PR looks like it's going to be very useful. However, these update_*.sh scripts are almost identical. I suggest refactoring a little further so that the 3 scripts can be "stubs" and call functions in a lib.sh or something. The stubs could then:

source lib.sh
Parse their arguments

Make calls like this:

clean $runtime_files

set_versions "$cc_shim_version" "$cc_shim_hash"

checkout_repo "$OBS_PROXY_REPO" ...

erick0z commented 7 years ago

@jodh-intel, As you suggested, I've split some functions into a new scripts/pkglib.sh. The remaining bits in each setup script are just properties needed for each component (like project names and static files, etc). Can you review this PR?

gorozco1 commented 7 years ago

@erick0z this commit has the "do not merge" label is still the case?