init: coredump on internal error

clearcontainers / proxy

Hypervisor based containers proxy

Apache License 2.0

32 stars 15 forks source link

init: coredump on internal error #142

Closed jodh-intel closed 7 years ago

jodh-intel commented 7 years ago

Override the default golang panic handling by printing a full traceback (not just for the current goroutine) and coredumping to allow crash-handling programs like apport to log the details.

Fixes #141.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

jodh-intel commented 7 years ago

Note that unlike the runtime (https://github.com/clearcontainers/runtime/issues/688), we could set this behaviour using the GOTRACEBACK environment variable in cc-proxy.service to allow the behaviour to be configurable. However, that could happen at a later date if really required (the ability to capture crash details is extremely useful so it's preferable not to disable the feature).

clearcontainersbot commented 7 years ago

kubernetes qa-passed 👍

jodh-intel commented 7 years ago

Also ref: https://github.com/clearcontainers/packaging/issues/135.