search

clearcontainers / proxy

Hypervisor based containers proxy
Apache License 2.0
32 stars 15 forks source link

One proxy per vm #167

Closed jodh-intel closed 6 years ago

jodh-intel commented 6 years ago

Allow the proxy to be run for a single pod.

This branch allows multiple proxies to be run on a single system, one per pod. Note that it also permits this behaviour even when the proxy is run as a system-level systemd service.

jodh-intel commented 6 years ago

Tested locally to ensure it is possible to run a system-level cc-proxy instance plus pod-level instances.

sboeuf commented 6 years ago

@jodh-intel oh ok so you mean with this patch, we can still use the proxy as a single instance ?

jodh-intel commented 6 years ago

Hi @sboeuf - yes, we can retain the systemd-spawned instance for the time being, then remove that functionality later. This multi-step process allows us to keep disruption to a minimum. See https://github.com/clearcontainers/runtime/issues/795.

sboeuf commented 6 years ago

@jodh-intel that's perfect to go step by step, I agree we don't want to break everyhting :)

clearcontainersbot commented 6 years ago

kubernetes qa-passed 👍

sboeuf commented 6 years ago

LGTM

sboeuf commented 6 years ago

@amshinde please take a look and merge this so that we can move forward with https://github.com/containers/virtcontainers/pull/483