search

clearcontainers / proxy

Hypervisor based containers proxy
Apache License 2.0
32 stars 15 forks source link

Remove unused features (socket activation and KSM) #177

Open jodh-intel opened 6 years ago

jodh-intel commented 6 years ago

Note that this cannot realistically land until we a stand-alone daemon to handle KSM, hence the dnm label.

See:

clearcontainersbot commented 6 years ago

kubernetes qa-failed 👎

jodh-intel commented 6 years ago

The tests are failing due to https://github.com/clearcontainers/tests/blob/master/.ci/install_proxy.sh#L34..L35 which is trying to modify the proxy's service file (which has been removed by this PR).

Once we have a KSM daemon, we can then:

clearcontainersbot commented 6 years ago

kubernetes qa-failed 👎

clearcontainersbot commented 6 years ago

kubernetes qa-failed 👎

clearcontainersbot commented 6 years ago

kubernetes qa-failed 👎

jodh-intel commented 6 years ago

Blocked on https://github.com/clearcontainers/tests/issues/913.

We cannot remove the KSM functionality from the proxy until the issue above is resolved since the tests currently install the proxy "manually" using:

(Note that user systems would not be affected by removing the functionality since they have the cc-ksm-throttler package installed already).

jodh-intel commented 6 years ago

Hi @chavafg, @grahamwhaley - now that https://github.com/clearcontainers/tests/pull/920 has landed, could you both confirm that I can continue with removing these features from the proxy?

grahamwhaley commented 6 years ago

Let me check some stuff. afaict when we landed https://github.com/clearcontainers/tests/pull/911 then the metrics CI got to do the right thing, but it then appears when we landed https://github.com/clearcontainers/tests/pull/920 it might be back to being nobbled again (that is, KSM seems to be in effect even when we try to turn it off). I'll have to go debug - which is made a fraction harder as the scripts don't generate any ack/nack/logs about what they are doing, so I have to go poke around the actual system... pls wait!

(oh, and apparently you need a rebase I think any how ;-) )

jodh-intel commented 6 years ago

yep - I'll hold off rebasing until I get two confirmations :)