search

clearcontainers / proxy

Hypervisor based containers proxy
Apache License 2.0
32 stars 15 forks source link

logging: Ensure journald identifier is simply "cc-proxy" #181

Closed jodh-intel closed 6 years ago

jodh-intel commented 6 years ago

Previously, the identifier used for each proxy log message specified the full path to the proxy binary. This meant that to select proxy log messages it was necessary to specify:

$ sudo journalctl -t /usr/libexec/clear-containers/cc-proxy

Now, the user can perform the same action with a simple:

$ sudo journalctl -t cc-proxy

Fixes #180.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

clearcontainersbot commented 6 years ago

kubernetes qa-passed 👍

grahamwhaley commented 6 years ago

just a thought - are there any scripts or tools that do log scraping and collating we need to update to match this ?

jodh-intel commented 6 years ago

Good question. The still-unfinished https://github.com/clearcontainers/tests/pull/590 circumvents the issue by requiring the user to pass the required journal extracts.

@sboeuf, @chavafg - can you check for anything else that might be impacted by this?

chavafg commented 6 years ago

@jodh-intel, @grahamwhaley we use sudo journalctl -u cc-proxy in the teardown.sh script, so we are fine. :)

jodh-intel commented 6 years ago

@chavafg - actually, "yes and no" - that now needs to be sudo journalctl -t cc-proxy due to https://github.com/clearcontainers/runtime/pull/835. We still launch the system-level cc-proxy instance, but it's inert and we'll be removing that soon when #177 lands.

chavafg commented 6 years ago

ohh, that's true, forgot about that change, then I'll open a PR to update it.

jodh-intel commented 6 years ago

Thanks!