tests: Disable file descriptor checks temporarily

clearcontainers / proxy

Hypervisor based containers proxy

Apache License 2.0

32 stars 15 forks source link

tests: Disable file descriptor checks temporarily #204

Closed amshinde closed 6 years ago

amshinde commented 6 years ago

With go 1.9.2, we are seeing file descriptor leaks in the tests. We need to revisit how we detect the file descriptor checks, disable the fd leaks checks to unblock other changes for now.

Signed-off-by: Archana Shinde archana.m.shinde@intel.com

sboeuf commented 6 years ago

@amshinde I am afraid if we do that, we will never enable it again...

clearcontainersbot commented 6 years ago

kubernetes qa-passed 👍

amshinde commented 6 years ago

@sboeuf I think we really need to re-evaluate and re-write these file descriptor checks. But do we need to invest doing that here, I would rather have this in the kata-proxy code base.

sboeuf commented 6 years ago

@amshinde this would make sense, but I don't think we can apply this to the kata case. The proxy is way more simple, and completely different.

clearcontainersbot commented 6 years ago

kubernetes qa-passed 👍

clearcontainersbot commented 6 years ago

kubernetes qa-passed 👍

sboeuf commented 6 years ago

@sameo @grahamwhaley

jodh-intel commented 6 years ago

I agree with @sboeuf - I'd rather we investigate further to identify what broke:

Are we sure it's the switch to go 1.9 that is triggering the issue for HEAD?
- If so, can we bisect to older versions of the code to find a commit where it doesn't fail with go 1.9?
- OOI, have you checked the behaviour with go 1.10 beta / tip?
We use go 1.8.3 for testing but I see we're using go 1.9.2 for packaging. I think that's technically a bug as we should be packaging using the same version we test with so I've raised: https://github.com/clearcontainers/packaging/issues/257.

amshinde commented 6 years ago

@jodh-intel We are seeing the CI fail after the switch to 1.9.2. I ran the same PR with 1.8.3 and 1.9.2 in a loop. I did not see any failures with 1.8.3, for around 100 interations, but I see failures in 1.9.2 within 10 iterations.