Fix file descriptor leak tests

clearcontainers / proxy

Hypervisor based containers proxy

Apache License 2.0

32 stars 15 forks source link

Fix file descriptor leak tests #205

Closed amshinde closed 6 years ago

amshinde commented 6 years ago

Close all KSM related fds that we create in our KSM tests.

While these are left open while running the proxy_test.go tests, where detecting leaking file descriptors is relevant, it looks like the open ksm fds get closed by the go runtime in the newer version of Go leading to different before and after file descriptor snapshots in the proxy_test.go tests.

Fixes #198

sboeuf commented 6 years ago

LGTM

clearcontainersbot commented 6 years ago

kubernetes qa-passed 👍

amshinde commented 6 years ago

@sameo Please take a look.

jodh-intel commented 6 years ago

Thanks for investigating and fixing this @amshinde.

lgtm