search

clearcontainers / runtime

OCI (Open Containers Initiative) compatible runtime using Virtual Machines
Apache License 2.0
589 stars 70 forks source link

logger: Fix nanosecond timestamp test #1018

Closed jodh-intel closed 6 years ago

jodh-intel commented 6 years ago

TestNewSystemLogHook() checks to ensure a nanonsecond timestamp is generated. However, the time.RFC3339Nano time format truncates trailing zeros meaning a nanosecond timestamp won't always have nine digits.

Fixes #1017.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

clearcontainersbot commented 6 years ago

kubernetes qa-passed 👍

devimc commented 6 years ago

lgtm

Approved with PullApprove Approved with PullApprove

jodh-intel commented 6 years ago

The metrics CI is again stopping the button from going green :-(

Force-merging as everything else is happy and this is causing the new release on #1021 to fail CI.

grahamwhaley commented 6 years ago

Just to note, the metrics CI failed due to a network/docker hub issue:

07:00:21 Get https://registry-1.docker.io/v2/library/nginx/manifests/sha256:600bff7fb36d7992512f8c07abd50aac08db8f17c94e3c83e47d53435a1a6f7c: net/http: TLS handshake timeout
07:00:21 ERROR: Failed to docker pull image nginx