clearcontainers / runtime

OCI (Open Containers Initiative) compatible runtime using Virtual Machines
Apache License 2.0
589 stars 70 forks source link

versions: Update recommended golang version. #1086

Closed jcvenegas closed 6 years ago

jcvenegas commented 6 years ago

Clear Containers CI uses go 1.9.4

Fixes: #1085

Signed-off-by: Jose Carlos Venegas Munoz jose.carlos.venegas.munoz@intel.com

grahamwhaley commented 6 years ago

Ubuntu CI failed - quick look at logs didn't show immediately why?

jcvenegas commented 6 years ago

@devimc ready to merge

jodh-intel commented 6 years ago

lgtm

Approved with PullApprove Approved with PullApprove

jodh-intel commented 6 years ago

Actually, there are a couple of issues here:

In summary:

We have a plan for how to resolve this for Kata but it's something we should be aware of I think:

/cc @sboeuf, @markdryan.

jcvenegas commented 6 years ago

@jodh-intel yes, that is one of the issues I see, first I want to reflect here the version we use to test. Today is not easy to test in the CI to a new golang version to check all works as expected. I added an script here https://github.com/clearcontainers/tests/pull/917/commits/af4ad939c2e60dab79b0f393f49ae355c8faef1f to allow change golang.

I require golang 1.10+ to allow cri-containerd in our CI.

jodh-intel commented 6 years ago

Nice - that would be useful in kata too. Let's merge this one then as a first-pass...