clearcontainers / runtime

OCI (Open Containers Initiative) compatible runtime using Virtual Machines
Apache License 2.0
589 stars 70 forks source link

config: Set agent type #912

Closed jodh-intel closed 6 years ago

jodh-intel commented 6 years ago

updateRuntimeConfig() was not setting the agent type, so if the runtime was configured for kata containers, it would try to use a hyperstart agent.

Fixes #911.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

jodh-intel commented 6 years ago

ping @sameo, @sboeuf.

sameo commented 6 years ago

Yes, I have exactly that fix on my local machine... LGTM

Approved with PullApprove Approved with PullApprove

clearcontainersbot commented 6 years ago

kubernetes qa-passed 👍

clearcontainersbot commented 6 years ago

kubernetes qa-passed 👍

jodh-intel commented 6 years ago

Ignoring known F26 failure...

sboeuf commented 6 years ago

Haha yes I have exactly the same fix too :)