cleardusk / 3DDFA_V2

The official PyTorch implementation of Towards Fast, Accurate and Stable 3D Dense Face Alignment, ECCV 2020.
MIT License
2.9k stars 514 forks source link

question about matrix2angle function #53

Open amyburden opened 3 years ago

amyburden commented 3 years ago

Thank you so much for this great work. I found a issue in DDFA_V2/utils/pose.py line 59. In the rotation matrix, matrix should like this, np.array([[ cos(y), 0, sin(y)], [ 0, 1, 0], [-sin(y), 0, cos(y)]]) you use x = asin(R[2, 0]) to calculate the angle which should be opsite value of the angle.