clearhaus / 3DSv2-api-documentation

Clearhaus 3D Secure v2 Server API documentation
4 stars 3 forks source link

Migrate from CircleCI to GHA #19

Closed cbobach closed 2 years ago

cbobach commented 2 years ago

Fixes https://github.com/clearhaus/issues-pci/issues/3108

cbobach commented 2 years ago

When this is approved I'll disable the CircleCI pipeline.

cbobach commented 2 years ago

@Lassejoe not sure what you are thinking off here. The dry run is only run on feature branches while the not dry-run one runs only on master.

The old file looks like this https://github.com/clearhaus/3DSv2-api-documentation/blob/b6ef11fbaa34b854bf60a0bf2629c4c207056631/.circleci/config.yml#L31-L40

This is what I've tried to carry on.

Lassejoe commented 2 years ago

@Lassejoe not sure what you are thinking off here. The dry run is only run on feature branches while the not dry-run one runs only on master.

The old file looks like this

https://github.com/clearhaus/3DSv2-api-documentation/blob/b6ef11fbaa34b854bf60a0bf2629c4c207056631/.circleci/config.yml#L31-L40

This is what I've tried to carry on.

My point is. The output of the dry-run is questionable. example:

 (dryrun) upload: build/_sources/specification_220.rst.txt to s3://clrhs-prod-nonpci-docs-3dsecure-io/3dsv2/_sources/specification_220.rst.txt
(dryrun) upload: build/_sources/specification_common.rst.txt to s3://clrhs-prod-nonpci-docs-3dsecure-io/3dsv2/_sources/specification_common.rst.txt

Since you haven't modified the files the files shouldn't appear in the dry runs output. It should have been skipped, IMO. https://docs.aws.amazon.com/cli/latest/reference/s3/sync.html#examples

cbobach commented 2 years ago

All the files in ./build/* is newly generated by the build step and may differ in size, and also timestamp and will thereby be uploaded.

cbobach commented 2 years ago

@Lassejoe your thoughts on moving on. Should I just merge this to se if we get something new in the s3 bucket?

I'll remove the unused secret when this is merged.

Lassejoe commented 2 years ago

It's just docs. Worst case we revert the branch. So just go ahead and merge