search

clearlinux / autospec

RPM packaging automation tool
GNU General Public License v3.0
100 stars 59 forks source link

make_install_args problem #450

Open jurobystricky opened 5 years ago

jurobystricky commented 5 years ago

I put "-C src " into my "make_install_args" file.

Then I ran autospec. As I expected, the spec file contained:

%make_install -C src

However the build failed, with the offending line in the build.log:

+ /usr/bin/make DESTDIR=/builddir/build/BUILDROOT/stockfish-10-1.x86_64 INSTALLROOT=/builddir/build/BUILDROOT/stockfish-10-1.x86_64 install_prefix=/builddir/build/BUILDROOT/stockfish-10-1.x86_64 BUILDROOT=/builddir/build/BUILDROOT/stockfish-10-1.x86_64 BUILD_ROOT=/builddir/build/BUILDROOT/stockfish-10-1.x86_64 INSTALL_ROOT=/builddir/build/BUILDROOT/stockfish-10-1.x86_64 install '%*'

Note the last '%*'. I would expect "-C src" instead.

phmccarty commented 5 years ago

@jurobystricky IIRC, rpm macros do not support passing arguments like that. Either we need to pass the arguments correctly or extend the %make_install macro to support it.