search

clearlinux / cloud-native-setup

Automation around setting up the cloud-native content (kubernetes) on Clear Linux.
Apache License 2.0
61 stars 41 forks source link

Fix rook single node setup #313

Closed CraigSterrett closed 4 years ago

CraigSterrett commented 4 years ago

Modified the rook installation to support both multinode kubernetes clusters and standalone kubernetes clusters. Multinode installations will occur as before, with changes for standalone installations. v0.8.3 I found it was not currently working and is too old to continue to support, will submit a PR for removing it. Also made a couple minor spacing changes to yaml as detected by yamllint

closes issue 306 https://github.com/clearlinux/cloud-native-setup/issues/306 closes issue 311 https://github.com/clearlinux/cloud-native-setup/issues/311

Signed-off-by: Craig Sterrett craig.Sterrett@intel.com

grahamwhaley commented 4 years ago

I think the code changes lgtm, but Ganesh is the master ;-) I also think I'm missing a subtlety - how does the kustomize choose whether to apply the singlenode or multinode - I didn't spot where the decision gets made, so maybe it is an implicit kustomize thing? (I find the kustomize docs hard to find/read/lacking....)

CraigSterrett commented 4 years ago

Dang, the reason you can't see how the kustomize is done is because my push missed that file, create_stack.sh has to be modified, the kustomize is called from within that script.