For review - Githubissues

clearlinux / clr-boot-manager

Kernel & Boot Loader Management

https://clearlinux.org/

111 stars 30 forks source link

For review #174

Closed dorileo closed 5 years ago

dorileo commented 5 years ago

split the root inspect into native and image - that way we can better visualize how the wanted mask is composed
add some cosmetic changes

dorileo commented 5 years ago

@bryteise I'll go thru all typos and look for others. Thanks.

dorileo commented 5 years ago

Added 2 more patches to this series, fixing extlinux config file and boot_dir "detection"/reconfiguration when mounting it - where it fixes a broken use case for systems without a partition for /boot.

The series finally bring back to life either extlinux and "partitionless" boot systems, fully enables syslinux. :)

dorileo commented 5 years ago

changes:

the patch c4a5a59c1d982586fd3419d662190ff2cbc7dc44 changes the approach and compares the sysconfig instead of checking if /boot is a subdir of /
fixed extlinux both on image and native mode
we were hardcoding vfat filesystem on the mount function, with that we couldn't have a /boot partition with other filesystems - making extlinux and grub2 support unusable

bryteise commented 5 years ago

Minor nits but otherwise this looks about ready to me.

dorileo commented 5 years ago

Pushed new version fixing the issues @bryteise identified.

bryteise commented 5 years ago

Looks great, thanks!