clearlinux / clr-installer

Clear Linux* OS Installer
GNU General Public License v3.0
92 stars 42 forks source link

Support software raid in Advanced partitioning flow #709

Closed karthikprabhuvinod closed 4 years ago

karthikprabhuvinod commented 4 years ago

Signed-off-by: Karthik Prabhu Vinod karthik.prabhu.vinod@intel.com

Partially Addresses : #8

Changes proposed in this pull request:

karthikprabhuvinod commented 4 years ago

@mdhorn : Not asking for review for merge, Just to get your thoughts on this?

mdhorn commented 4 years ago

@mdhorn : Not asking for review for merge, Just to get your thoughts on this?

This is a good start, and I used this PR to create an install -- which of course doesn't boot, but gives me a testing framework. The changes you should make are moving those checks from WritePartition table to the Findxxxx routines. The pre-existing check was mainly a sanity check for writing the partitions. The checking should be done in the Findxxx routines to screen out. We should be flagging that /boot must be a physical disk there so the message is conveyed back to the user.

mdhorn commented 4 years ago

Fixed in installer release 2.5.0 found in Clear Linux OS release 32980 or greater.